Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User inventory rule #16972

Merged
merged 10 commits into from
May 15, 2024
Merged

User inventory rule #16972

merged 10 commits into from
May 15, 2024

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Apr 22, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets !32435

Add new options in rules to manage user reconciliation.
image

@Lainow Lainow marked this pull request as draft April 22, 2024 13:00
@Lainow Lainow self-assigned this Apr 22, 2024
@Lainow Lainow marked this pull request as ready for review April 23, 2024 14:02
@Lainow Lainow requested a review from stonebuzz April 23, 2024 14:02
src/RuleAsset.php Outdated Show resolved Hide resolved
src/RuleAsset.php Outdated Show resolved Hide resolved
src/RuleAsset.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from stonebuzz April 24, 2024 14:01
src/RuleAsset.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from stonebuzz May 6, 2024 10:13
@stonebuzz
Copy link
Contributor

waiting for customer feedback

src/RuleAsset.php Outdated Show resolved Hide resolved
src/RuleAsset.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne added this to the 11.0.0 milestone May 13, 2024
Lainow and others added 3 commits May 14, 2024 15:46
@cedric-anne
Copy link
Member

I fixed the indentation and renamed the _user_inventory criteria/vars to _inventory_users, as it contains multiple values.

@cedric-anne cedric-anne merged commit 7114ae9 into glpi-project:main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants